Skip to content

fix(ci): add setup-terraform to prevent flaky test failures#701

Merged
tembleking merged 1 commit intomasterfrom
fix/ci-setup-terraform
Feb 10, 2026
Merged

fix(ci): add setup-terraform to prevent flaky test failures#701
tembleking merged 1 commit intomasterfrom
fix/ci-setup-terraform

Conversation

@tembleking
Copy link
Copy Markdown
Member

Summary

  • Add hashicorp/setup-terraform@v3 step to all 4 acceptance test jobs (test-sysdig-secure, test-sysdig-monitor, test-ibm-monitor, test-ibm-secure)
  • Uses terraform_wrapper: false to avoid interference with programmatic CLI usage from Go tests
  • Fixes flaky CI failures caused by terraform-plugin-testing trying to dynamically download Terraform CLI from checkpoint-api.hashicorp.com, which returns timeouts and 502 errors

Context

All 3 test failures in this CI run share the same root cause:

failed to find or install Terraform CLI: Get "https://checkpoint-api.hashicorp.com/v1/check/terraform?...": context deadline exceeded

Test plan

  • CI acceptance tests pass without checkpoint-api.hashicorp.com availability issues

The terraform-plugin-testing framework dynamically downloads the
Terraform CLI from checkpoint-api.hashicorp.com, which is unreliable
(timeouts, 502s). Pre-install Terraform via hashicorp/setup-terraform
in all acceptance test jobs.
Copilot AI review requested due to automatic review settings February 10, 2026 15:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Terraform CLI setup to CI acceptance test jobs to eliminate flaky failures caused by dynamic Terraform downloads during tests.

Changes:

  • Adds hashicorp/setup-terraform@v3 to all four acceptance test jobs.
  • Disables terraform_wrapper to avoid interfering with Terraform CLI usage from Go tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
@tembleking tembleking enabled auto-merge February 10, 2026 15:25
@tembleking tembleking added this pull request to the merge queue Feb 10, 2026
Merged via the queue into master with commit 49c9d2a Feb 10, 2026
171 checks passed
@tembleking tembleking deleted the fix/ci-setup-terraform branch February 10, 2026 15:40
fcracker79 pushed a commit that referenced this pull request Mar 5, 2026
## Summary
- Add `hashicorp/setup-terraform@v3` step to all 4 acceptance test jobs
(`test-sysdig-secure`, `test-sysdig-monitor`, `test-ibm-monitor`,
`test-ibm-secure`)
- Uses `terraform_wrapper: false` to avoid interference with
programmatic CLI usage from Go tests
- Fixes flaky CI failures caused by `terraform-plugin-testing` trying to
dynamically download Terraform CLI from `checkpoint-api.hashicorp.com`,
which returns timeouts and 502 errors

## Context
All 3 test failures in [this CI
run](https://github.com/sysdiglabs/terraform-provider-sysdig/actions/runs/21869038206)
share the same root cause:
```
failed to find or install Terraform CLI: Get "https://checkpoint-api.hashicorp.com/v1/check/terraform?...": context deadline exceeded
```

## Test plan
- [ ] CI acceptance tests pass without checkpoint-api.hashicorp.com
availability issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants